refactor: move validation structs and add account field#589
Open
Battambang wants to merge 3 commits intomainfrom
Open
refactor: move validation structs and add account field#589Battambang wants to merge 3 commits intomainfrom
Battambang wants to merge 3 commits intomainfrom
Conversation
…ddress } to all request types
…quest for integration tests
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This was referenced Mar 16, 2026
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR contributes to supporting the Bitcoin dApp connectivity.
It's refactoring the current code to prepare the integration of the resolve account address Keyring method.
It is part from the initial PR #564 feat: enable account address resolution to support dApps connectivity to split the work into 3 smaller PRs:
#589 refactor: move validation structs and add account field
#590 feat: add resolveAccountAddress method to KeyringHandler for dApp connectivity routing
#591 feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler
References
Checklist
Note
Medium Risk
Changes the validated shape of keyring request
paramsby requiring an embeddedaccountobject (withaddress) across multiple Bitcoin RPC methods, which can break callers if they don’t update. Logic changes are mostly structural (validation refactor), but they gate core signing/broadcast/transfer flows.Overview
Keyring request validation was refactored and tightened. Request
superstructschemas forSignPsbt,FillPsbt,ComputeFee,BroadcastPsbt,SendTransfer,GetUtxo, andSignMessagewere moved out ofKeyringRequestHandlerintohandlers/validation.tsand updated to requireparams.account(currently{ address }).Keyring method typing/validation was expanded.
validation.tsnow defines per-method keyring request structs keyed byBtcMethod(vialiteral(...)) and aBtcWalletRequestStructunion for validating supported Bitcoin wallet requests.Tests were updated accordingly (unit + integration) to pass the new
accountparam shape,caip.tsaddsNetworkStructfor validatingBtcScopevalues, andsnap.manifest.jsonshasumwas updated to match the rebuilt bundle.Written by Cursor Bugbot for commit bee05b0. This will update automatically on new commits. Configure here.