Skip to content

fix: enable Corepack in update-snap-version release job#619

Merged
mathieuartu merged 1 commit into
mainfrom
fix/ci-enable-corepack-update-snap-version
Jun 17, 2026
Merged

fix: enable Corepack in update-snap-version release job#619
mathieuartu merged 1 commit into
mainfrom
fix/ci-enable-corepack-update-snap-version

Conversation

@mathieuartu

@mathieuartu mathieuartu commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

What

Swap the raw actions/checkout@v4 + actions/setup-node@v4 pair in the update-snap-version job of .github/workflows/create-release-pr.yml for MetaMask/action-checkout-and-setup@v1, matching the pattern this repo's build-lint-test.yml already uses.

Why

Surfaced by #614 (chore: bump Yarn to 4.17.0). The update-snap-version job runs yarn --immutable directly on the runner, but it wasn't enabling Corepack, so it fell back to ubuntu-latest's global Yarn 1.22 and bailed:

error This project's package.json defines "packageManager": "yarn@4.17.0". However the current global version of Yarn is 1.22.22.

The composite action enables Corepack and installs the pinned Yarn 4.17.0, so yarn --immutable resolves the right binary.

Notes

  • The first job (create-release-pr) still uses raw actions/checkout + actions/setup-node. It keeps working because MetaMask/action-create-release-pr@v3 self-bootstraps.

@mathieuartu mathieuartu self-assigned this Jun 17, 2026
@mathieuartu mathieuartu requested a review from a team as a code owner June 17, 2026 14:55
@mathieuartu mathieuartu changed the title fix: enable Corepack in update-snap-version release job fix: enable Corepack in update-snap-version release job Jun 17, 2026
@mathieuartu mathieuartu merged commit c10db57 into main Jun 17, 2026
7 checks passed
@mathieuartu mathieuartu deleted the fix/ci-enable-corepack-update-snap-version branch June 17, 2026 14:58
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants