Merged
Conversation
Montoya
requested changes
Feb 7, 2025
Contributor
Montoya
left a comment
Montoya
left a comment
There was a problem hiding this comment.
On this line: https://github.com/qubic/qubic-mm-snap/blob/main/src/index.js#L18 the Snap allows the origin of a request to be passed as a parameter in the request. This means any dapp can pretend to be any URL it wants? I could fire a request with the parameter "opensea.com" as the origin and it will make it look like the request is coming from opensea.com. Is that intentional? Seems like a security issue.
Collaborator
Author
|
They are preparing an update @Montoya to remove this as they don't use it anyway. Good catch! |
Collaborator
Author
|
@Montoya here is the update to fix the mentioned security issue qubic/qubic-mm-snap@26a8772 |
mario-christopher
approved these changes
Mar 6, 2025
Montoya
approved these changes
Mar 6, 2025
Mrtenz
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1060