Skip to content

fix(eid-wallet): strip alpha channel from iOS app icons#976

Merged
coodos merged 3 commits into
mainfrom
fix/ios-icon-alpha
May 28, 2026
Merged

fix(eid-wallet): strip alpha channel from iOS app icons#976
coodos merged 3 commits into
mainfrom
fix/ios-icon-alpha

Conversation

@coodos

@coodos coodos commented May 28, 2026

Copy link
Copy Markdown
Contributor

Apple rejected the build with "invalid large app icon, can't contain alpha channel".

All 18 icons in the iOS AppIcon.appiconset carried an unused alpha channel (the 1024x1024 marketing icon AppIcon-512@2x.png is the one App Store Connect flags). The icons were already visually opaque (white-backed), so flattening to opaque sRGB removes the channel without changing appearance.

Dimensions and colorspace unchanged.

Note: the Tauri source icons/icon.png still has a transparent background, so re-running tauri icon will reintroduce alpha on the iOS set. A follow-up could flatten the master or add a post-generation step, but that touches Android/macOS/Windows output too, so it's left out here.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@coodos, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5501618a-5168-4628-92ee-757507e1d629

📥 Commits

Reviewing files that changed from the base of the PR and between 0cbf149 and adf57de.

⛔ Files ignored due to path filters (20)
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-20x20@1x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-20x20@2x-1.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-20x20@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-20x20@3x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-29x29@1x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-29x29@2x-1.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-29x29@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-29x29@3x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-40x40@1x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-40x40@2x-1.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-40x40@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-40x40@3x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-512@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-60x60@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-60x60@3x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-76x76@1x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-76x76@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/apple/Assets.xcassets/AppIcon.appiconset/AppIcon-83.5x83.5@2x.png is excluded by !**/*.png, !**/gen/**
  • infrastructure/eid-wallet/static/images/binding-documents.png is excluded by !**/*.png
  • infrastructure/eid-wallet/static/images/what-is-evault.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • infrastructure/eid-wallet/src-tauri/tauri.conf.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ios-icon-alpha

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos coodos merged commit 0c5e5ed into main May 28, 2026
4 checks passed
@coodos coodos deleted the fix/ios-icon-alpha branch May 28, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant