Conversation
Expand for detailed file sizes
|
Contributor
|
Pretty MainDeckRoom0 (which has the value 0) actually represents not being in a nav room |
cluekitty
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if this is the best approach to fix it, or if this breaks anything else. I quickly double checked boss doors too and they seemed fine.
in decomp its this part: https://github.com/metroidret/mf/blob/35f6d719ea47eb94586f2c12aede6b700f261a94/asm/disasm_0x080645c4.s#L2715 . As it's not been decompiled yet, i looked the ghidra output for some reference, but that seems a bit broken, as the first check for that dma transfer is
CurrentNavigationRoom == MainDeckRoom0. And stabilizers are not navigation rooms.Probably would be a tiny bit faster for cycles if i'd stub out the whole comparisons out, but this seemed slightly easier.
Fixes #381