Skip to content

Fix: permanently locked doors animating#383

Merged
cluekitty merged 1 commit intomainfrom
no-animation
Feb 18, 2026
Merged

Fix: permanently locked doors animating#383
cluekitty merged 1 commit intomainfrom
no-animation

Conversation

@Miepee
Copy link
Copy Markdown
Contributor

@Miepee Miepee commented Feb 17, 2026

I'm not quite sure if this is the best approach to fix it, or if this breaks anything else. I quickly double checked boss doors too and they seemed fine.

in decomp its this part: https://github.com/metroidret/mf/blob/35f6d719ea47eb94586f2c12aede6b700f261a94/asm/disasm_0x080645c4.s#L2715 . As it's not been decompiled yet, i looked the ghidra output for some reference, but that seems a bit broken, as the first check for that dma transfer is CurrentNavigationRoom == MainDeckRoom0. And stabilizers are not navigation rooms.

Probably would be a tiny bit faster for cycles if i'd stub out the whole comparisons out, but this seemed slightly easier.

Fixes #381

@Miepee Miepee requested review from biosp4rk and cluekitty February 17, 2026 13:48
@github-actions
Copy link
Copy Markdown

Expand for detailed file sizes

File Size (Bytes)
accessibility.ips 4373
missiles_without_mains.ips 50
nerf_geron_weakness.ips 243
unhidden_map.ips 37
unhidden_map_doors.ips 40

@biosp4rk
Copy link
Copy Markdown
Contributor

Pretty MainDeckRoom0 (which has the value 0) actually represents not being in a nav room

@cluekitty cluekitty merged commit 383de7a into main Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permanently Locked doors animate when an in-room event would have normally unlocked the door

3 participants