Skip to content

Separate schema and patcher.py#174

Merged
Miepee merged 6 commits intomainfrom
zm
Sep 8, 2025
Merged

Separate schema and patcher.py#174
Miepee merged 6 commits intomainfrom
zm

Conversation

@biosp4rk
Copy link
Copy Markdown
Collaborator

@biosp4rk biosp4rk commented Sep 8, 2025

  • Added directories for fusion (mf) and zero mission (zm)
    • Moved data directory to /mf
    • Other fusion stuff is left as is, will move it over in pieces later
  • Added schema for zero mission
  • Modified pre-commit to auto generate type for both schemas
  • Added patcher_mf.py and patcher_zm.py; patcher.py will call the appropriate one based on the rom

],
"default": null
},
"intro_text": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

food for thought, but may be worth to have a setting to skip the intro entirely

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the intro text a good way to convey the objective to the player?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, but its more or less useless if you already know the objective.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a "skip cutscenes setting" (haven't added it to the schema yet), could lump it in with that

"minimum": 0,
"maximum": 360
},
"valid_sources": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

food for thought: in the future, it might be worth adding kraid and ridley to here too

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like defeating the boss itself gives you an item?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. was mostly thinking in case that we want to randomize what unlocks the statue-path and not have a hard required kraid+ridley to go to tourian.

@Miepee Miepee merged commit 2fa5304 into main Sep 8, 2025
8 checks passed
@biosp4rk biosp4rk deleted the zm branch September 8, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants