Conversation
Collaborator
biosp4rk
commented
Sep 8, 2025
biosp4rk
commented
- Shared code is in credits.py
- Shared constants are in constants/credits.py
- Fusion code for replacing credits is in mf/credits.py
- Fusion credits data is in mf/constants/credits_lines.py
Miepee
approved these changes
Sep 8, 2025
Comment on lines
+10
to
+13
| COPYRIGHT1 = 5 | ||
| COPYRIGHT2 = 6 | ||
| COPYRIGHT3 = 7 | ||
| COPYRIGHT4 = 8 |
Contributor
There was a problem hiding this comment.
surprised to see that both fusion and zm have 4 copyrights
Collaborator
Author
There was a problem hiding this comment.
They're basically the same https://github.com/metroidret/mzm/blob/master/include/constants/ending_and_gallery.h#L25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.