Conversation
| return 0xF | ||
|
|
||
|
|
||
| def starting_equipment(rom: Rom) -> int: |
There was a problem hiding this comment.
does zm not have starting equipment?
There was a problem hiding this comment.
It does, but in a different format. I could put it with the other shared data, but we probably won't have shared code for setting the equipment
| raise ValueError(rom.region) | ||
|
|
||
|
|
||
| def file_screen_text_ptrs(rom: Rom) -> int: |
There was a problem hiding this comment.
what exactly is meant with "text pointers" here? pointers to any text on the file select (e.g Energy, Time, Sound, Exit etc.) or just the samus data at the top?
There was a problem hiding this comment.
It's the list of pointers to text on the title screen. I think you can see the different text entries in mage. I believe currently we only edit the entry that says Samus data. In ZM it uses a custom graphic at the top instead of using text
| from mars_patcher.rom import Game, Region, Rom | ||
|
|
||
|
|
||
| def area_room_entry_ptrs(rom: Rom) -> int: |
There was a problem hiding this comment.
so we decided on not moving these into a json?
There was a problem hiding this comment.
We could if we want. I don't feel strongly either way
Miepee
left a comment
Miepee
left a comment
There was a problem hiding this comment.
Fine with this for now, but may need a second look regarding starting_equipment and title_screen_text in the future.
2 participants
Data that both games have is in constants/game_data.py, and data unique to fusion is in mf/constants/game_data.py