Move fusion minimap edits out of shared code#181
Conversation
|
I did the base edits originally - I thought I followed the schema, could you point out what was different? I would say we absolutely want to be following the schema. (It's hard to tell based on the diff) EDIT: Looks like I maybe just didn't follow it right 🙃 |
Schema follows this format: The base edits looked like this: |
Miepee
left a comment
There was a problem hiding this comment.
Technically having a "Description" property does not fail the schema as we don't enforce an "additionalProperties: false"
Maybe in the future we move it to a dictionary in a python file instead and then use proper comments instead of a comment-field. But that'd affect a few other jsons we have too.
The only fusion specific code in minimap.py was for applying the base edits, which weirdly uses a similar but slightly different format than the one defined in the schema. I modified the base edits json to match the format from the schema, but if we want, we could keep the previous format of the json and change the one in the schema instead.