Skip to content

Move fusion minimap edits out of shared code#181

Merged
Miepee merged 1 commit intomainfrom
zm7-refactor-minimap
Sep 10, 2025
Merged

Move fusion minimap edits out of shared code#181
Miepee merged 1 commit intomainfrom
zm7-refactor-minimap

Conversation

@biosp4rk
Copy link
Copy Markdown
Collaborator

The only fusion specific code in minimap.py was for applying the base edits, which weirdly uses a similar but slightly different format than the one defined in the schema. I modified the base edits json to match the format from the schema, but if we want, we could keep the previous format of the json and change the one in the schema instead.

@zarakava
Copy link
Copy Markdown
Contributor

zarakava commented Sep 10, 2025

I did the base edits originally - I thought I followed the schema, could you point out what was different? I would say we absolutely want to be following the schema. (It's hard to tell based on the diff)

EDIT: Looks like I maybe just didn't follow it right 🙃

@biosp4rk
Copy link
Copy Markdown
Collaborator Author

I did the base edits originally - I thought I followed the schema, could you point out what was different? I would say we absolutely want to be following the schema. (It's hard to tell based on the diff)

Schema follows this format:

    "0": [
        {
            "Description": "Sector 1 Marker from Restricted Lab",
            "X": 7,
            "Y": 18,
            "Tile": 172,
            "Palette": 0
        },
        ...
    "1": [
        ...

The base edits looked like this:

        "MAP_ID": 0,
        "CHANGES": [
            {
                "Description": "Sector 1 Marker from Restricted Lab",
                "X": 7,
                "Y": 18,
                "Tile": 172,
                "Palette": 0
            },
            ...

Copy link
Copy Markdown
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically having a "Description" property does not fail the schema as we don't enforce an "additionalProperties: false"
Maybe in the future we move it to a dictionary in a python file instead and then use proper comments instead of a comment-field. But that'd affect a few other jsons we have too.

@Miepee Miepee merged commit 2ab873a into main Sep 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants