Conversation
Collaborator
Author
|
Also I've been suffixing names with |
Miepee
reviewed
Sep 11, 2025
| from mars_patcher.zm.constants.game_data import statues_cutscene_palette_addr | ||
| from mars_patcher.zm.constants.sprites import SpriteIdZM | ||
|
|
||
| HueRange: TypeAlias = tuple[int, int] |
Contributor
There was a problem hiding this comment.
for the future, it may be better to make this a named tuple
Comment on lines
+80
to
+84
| RINKA_MOTHER_BRAIN_C9 = 0xC9 | ||
| RINKA_MOTHER_BRAIN_CA = 0xCA | ||
| RINKA_MOTHER_BRAIN_CB = 0xCB | ||
| RINKA_MOTHER_BRAIN_CC = 0xCC | ||
| RINKA_MOTHER_BRAIN_CD = 0xCD |
Contributor
There was a problem hiding this comment.
do these really not have better names apart from C9-CD?
Collaborator
Author
There was a problem hiding this comment.
Not really, I think decomp names them 1 2 3 4 5
Miepee
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the constants are dictionaries keyed by Game, we could also split them and put them in
/mfand/zmThe interaction between the sprite ID IntEnums and normal ints is a bit awkward. I opted to convert the IDs to normal ints (see random_enemies.py line 11 as an example). There may be a cleaner way to do some of this, open to feedback