Merged
Conversation
Miepee
approved these changes
Sep 19, 2025
| class ItemMessages: | ||
| kind: ItemMessagesKind | ||
| item_messages: frozendict[Language, str] | ||
| centered: bool |
Contributor
There was a problem hiding this comment.
now that i see this: i suppose it doesnt make much sense to e.g. have english centered, but not german? (or in other words, have the centered variable be per lang)
| rom.write_8(minor_loc_addr + 0xC, min_loc.hint_value) | ||
| minor_loc_addr += 0x10 | ||
|
|
||
| if min_loc.hinted_by != HintLocation.NONE: |
Contributor
There was a problem hiding this comment.
i feel like this hint system is way too overpowered, but that's a thing for later.
Miepee
reviewed
Sep 19, 2025
Miepee
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.