Allow changing minimap tiles with hatches that exist in multiple versions of same room#209
Merged
Allow changing minimap tiles with hatches that exist in multiple versions of same room#209
Conversation
Miepee
reviewed
Dec 11, 2025
|
|
||
| MinimapLocation = tuple[int, int, RoomId] | ||
| """`(X, Y, RoomId)`""" | ||
| MinimapLocation = tuple[int, int] |
Contributor
There was a problem hiding this comment.
makes me wonder if this should be a namedtuple
but its probably not used often enough? and afaik we're basically always unpacking the tuple anyway.
Miepee
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimap changes don't need to track what room a hatch is in, only the coordinates. I added a check to make sure the same tile isn't changed in two different ways
I also removed some blank tile IDs that should be reserved for new transparent tiles