Skip to content

refactor: remove any casts for prisma client models #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peaostrel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove any casts for prisma client models #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions src/commissions/commissions.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class CommissionsService {
const amount = transaction.amount.mul(agentAssignment.commissionRate);

// Check if commission record already exists
const existing = await (this.prisma as any).commission.findUnique({
const existing = await this.prisma.commission.findUnique({
where: {
transactionId_agentId: {
transactionId,
Expand All @@ -65,7 +65,7 @@ export class CommissionsService {
continue;
}

await (this.prisma as any).commission.create({
await this.prisma.commission.create({
data: {
transactionId,
agentId: agentAssignment.agentId,
Expand Down Expand Up @@ -96,7 +96,7 @@ export class CommissionsService {
const dbStatus =
status === 'COMPLETED' ? 'COMPLETED' : status === 'CANCELLED' ? 'CANCELLED' : 'PENDING';

const result = await (this.prisma as any).commission.updateMany({
const result = await this.prisma.commission.updateMany({
where: { transactionId },
data: { status: dbStatus as any },
});
Expand Down Expand Up @@ -142,7 +142,7 @@ export class CommissionsService {
}

const [items, total] = await Promise.all([
(this.prisma as any).commission.findMany({
this.prisma.commission.findMany({
where,
skip,
take: limit,
Expand Down Expand Up @@ -172,7 +172,7 @@ export class CommissionsService {
},
orderBy: { createdAt: 'desc' },
}),
(this.prisma as any).commission.count({ where }),
this.prisma.commission.count({ where }),
]);

return {
Expand All @@ -195,7 +195,7 @@ export class CommissionsService {
* Find details of a single commission record
*/
async findOne(id: string, user: AuthUserPayload) {
const commission = await (this.prisma as any).commission.findUnique({
const commission = await this.prisma.commission.findUnique({
where: { id },
include: {
agent: {
Expand Down Expand Up @@ -256,31 +256,31 @@ export class CommissionsService {
async getStats(user: AuthUserPayload) {
if (user.role === 'ADMIN') {
// Global Statistics
const completedAgg = await (this.prisma as any).commission.aggregate({
const completedAgg = await this.prisma.commission.aggregate({
_sum: { amount: true },
where: { status: 'COMPLETED' },
});

const pendingAgg = await (this.prisma as any).commission.aggregate({
const pendingAgg = await this.prisma.commission.aggregate({
_sum: { amount: true },
where: { status: 'PENDING' },
});

const cancelledAgg = await (this.prisma as any).commission.aggregate({
const cancelledAgg = await this.prisma.commission.aggregate({
_sum: { amount: true },
where: { status: 'CANCELLED' },
});

// Get count of completed vs pending
const completedCount = await (this.prisma as any).commission.count({
const completedCount = await this.prisma.commission.count({
where: { status: 'COMPLETED' },
});
const pendingCount = await (this.prisma as any).commission.count({
const pendingCount = await this.prisma.commission.count({
where: { status: 'PENDING' },
});

// Breakdown per agent
const commissions = await (this.prisma as any).commission.findMany({
const commissions = await this.prisma.commission.findMany({
include: {
agent: {
select: {
Expand Down Expand Up @@ -330,21 +330,21 @@ export class CommissionsService {
};
} else {
// Agent-specific Statistics
const completedAgg = await (this.prisma as any).commission.aggregate({
const completedAgg = await this.prisma.commission.aggregate({
_sum: { amount: true },
where: { agentId: user.sub, status: 'COMPLETED' },
});

const pendingAgg = await (this.prisma as any).commission.aggregate({
const pendingAgg = await this.prisma.commission.aggregate({
_sum: { amount: true },
where: { agentId: user.sub, status: 'PENDING' },
});

const completedCount = await (this.prisma as any).commission.count({
const completedCount = await this.prisma.commission.count({
where: { agentId: user.sub, status: 'COMPLETED' },
});

const pendingCount = await (this.prisma as any).commission.count({
const pendingCount = await this.prisma.commission.count({
where: { agentId: user.sub, status: 'PENDING' },
});

Expand Down
6 changes: 3 additions & 3 deletions src/duplicate-detection/duplicate-detection.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export class DuplicateDetectionService {
}

async getFlags(): Promise<any[]> {
return (this.prisma as any).propertyDuplicate.findMany({
return this.prisma.propertyDuplicate.findMany({
where: { flaggedForReview: true, isMerged: false, isResolved: false },
include: {
property: {
Expand All @@ -282,13 +282,13 @@ export class DuplicateDetectionService {
}

async resolveFlag(flagId: string): Promise<any> {
const flag = await (this.prisma as any).propertyDuplicate.findUnique({
const flag = await this.prisma.propertyDuplicate.findUnique({
where: { id: flagId },
});
if (!flag) {
throw new NotFoundException('Duplicate flag not found');
}
return (this.prisma as any).propertyDuplicate.update({
return this.prisma.propertyDuplicate.update({
where: { id: flagId },
data: { isResolved: true },
});
Expand Down
26 changes: 13 additions & 13 deletions src/properties/properties.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ export class PropertiesService {
throw new BadRequestException('Assigned user must have the AGENT role');
}

const existing = await (this.prisma as any).propertyAgent.findUnique({
const existing = await this.prisma.propertyAgent.findUnique({
where: {
propertyId_agentId: {
propertyId,
Expand All @@ -861,7 +861,7 @@ export class PropertiesService {
throw new BadRequestException('Agent is already assigned to this property');
}

return (this.prisma as any).propertyAgent.create({
return this.prisma.propertyAgent.create({
data: {
propertyId,
agentId: dto.agentId,
Expand Down Expand Up @@ -905,7 +905,7 @@ export class PropertiesService {
);
}

const assignment = await (this.prisma as any).propertyAgent.findUnique({
const assignment = await this.prisma.propertyAgent.findUnique({
where: {
propertyId_agentId: {
propertyId,
Expand All @@ -917,7 +917,7 @@ export class PropertiesService {
throw new NotFoundException('Agent assignment not found for this property');
}

return (this.prisma as any).propertyAgent.update({
return this.prisma.propertyAgent.update({
where: {
propertyId_agentId: {
propertyId,
Expand Down Expand Up @@ -958,7 +958,7 @@ export class PropertiesService {
);
}

const assignment = await (this.prisma as any).propertyAgent.findUnique({
const assignment = await this.prisma.propertyAgent.findUnique({
where: {
propertyId_agentId: {
propertyId,
Expand All @@ -970,7 +970,7 @@ export class PropertiesService {
throw new NotFoundException('Agent assignment not found for this property');
}

return (this.prisma as any).propertyAgent.delete({
return this.prisma.propertyAgent.delete({
where: {
propertyId_agentId: {
propertyId,
Expand All @@ -988,7 +988,7 @@ export class PropertiesService {
throw new NotFoundException('Property not found');
}

const assignments = await (this.prisma as any).propertyAgent.findMany({
const assignments = await this.prisma.propertyAgent.findMany({
where: { propertyId },
include: {
agent: {
Expand Down Expand Up @@ -1023,7 +1023,7 @@ export class PropertiesService {
if (!property) {
throw new NotFoundException('Property not found');
}
return (this.prisma as any).propertyAmenity.create({
return this.prisma.propertyAmenity.create({
data: {
propertyId,
name: dto.name,
Expand All @@ -1039,20 +1039,20 @@ export class PropertiesService {
if (!property) {
throw new NotFoundException('Property not found');
}
return (this.prisma as any).propertyAmenity.findMany({
return this.prisma.propertyAmenity.findMany({
where: { propertyId },
orderBy: { createdAt: 'asc' },
});
}

async updateAmenity(propertyId: string, amenityId: string, dto: UpdateAmenityDto) {
const amenity = await (this.prisma as any).propertyAmenity.findUnique({
const amenity = await this.prisma.propertyAmenity.findUnique({
where: { id: amenityId },
});
if (!amenity || amenity.propertyId !== propertyId) {
throw new NotFoundException('Amenity not found for this property');
}
return (this.prisma as any).propertyAmenity.update({
return this.prisma.propertyAmenity.update({
where: { id: amenityId },
data: {
name: dto.name,
Expand All @@ -1064,12 +1064,12 @@ export class PropertiesService {
}

async removeAmenity(propertyId: string, amenityId: string) {
const amenity = await (this.prisma as any).propertyAmenity.findUnique({
const amenity = await this.prisma.propertyAmenity.findUnique({
where: { id: amenityId },
});
if (!amenity || amenity.propertyId !== propertyId) {
throw new NotFoundException('Amenity not found for this property');
}
return (this.prisma as any).propertyAmenity.delete({ where: { id: amenityId } });
return this.prisma.propertyAmenity.delete({ where: { id: amenityId } });
}
}
8 changes: 4 additions & 4 deletions src/support-tickets/support-tickets.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,29 @@ export class SupportTicketsService {

async addInternalNote(ticketId: string, authorId: string, content: string) {
await this.assertTicketExists(ticketId);
return (this.prisma as any).transactionNote.create({
return this.prisma.transactionNote.create({
data: { transactionId: ticketId, authorId, content, isPublic: false },
});
}

async addPublicReply(ticketId: string, authorId: string, content: string) {
await this.assertTicketExists(ticketId);
return (this.prisma as any).transactionNote.create({
return this.prisma.transactionNote.create({
data: { transactionId: ticketId, authorId, content, isPublic: true },
});
}

async listForAgent(ticketId: string) {
await this.assertTicketExists(ticketId);
return (this.prisma as any).transactionNote.findMany({
return this.prisma.transactionNote.findMany({
where: { transactionId: ticketId },
orderBy: { createdAt: 'asc' },
});
}

async listPublicForUser(ticketId: string) {
await this.assertTicketExists(ticketId);
return (this.prisma as any).transactionNote.findMany({
return this.prisma.transactionNote.findMany({
where: { transactionId: ticketId, isPublic: true },
orderBy: { createdAt: 'asc' },
});
Expand Down
2 changes: 1 addition & 1 deletion src/transactions/transaction-reminders.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class TransactionRemindersService {
sent++;
}

await (this.prisma as any).transactionMilestone.update({
await this.prisma.transactionMilestone.update({
where: { id: milestone.id },
data: { reminderSentAt: new Date() },
});
Expand Down
Loading