Fix: Inconsistent Error Messages.#149
Merged
LaGodxy merged 1 commit intoMettaChain:mainfrom Mar 29, 2026
Merged
Conversation
|
@Lansa-18 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@LaGodxy Kindly go through chief. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103
Error Message Standardization
Bug Fixes
OracleError::BatchSizeExceeded— replaced hardcoded literal4012with named constantoracle_codes::ORACLE_BATCH_SIZE_EXCEEDEDcompliance_registry::Error— fixed 8 error variants that were mapped to wrong or duplicate codes (e.g.HighRisk,ProhibitedJurisdiction,InvalidRiskScore, andJurisdictionNotSupportedall incorrectly sharedCOMPLIANCE_CHECK_FAILED)New Infrastructure
ErrorMessagestructcode,category,message,description, andi18n_keyinto a single typeContractError::error_i18n_key()"category.variant"dot-notation key (e.g."compliance.not_verified")ContractError::to_error_message()ErrorMessagefrom any error, zero allocationi18n.rsmoduleSupportedLocale,LocalizedMessage,lookup(), andlookup_default()using static match-based lookup (fullyno_stdcompatible)New Constants
oracle_codes::ORACLE_BATCH_SIZE_EXCEEDED = 4012compliance_codesconstants:COMPLIANCE_HIGH_RISKthroughCOMPLIANCE_DATA_RETENTION_EXPIRED(6006–6013)Localization Keys
All 38 keys implemented across four categories:
common.*·oracle.*·compliance.*·monitoring.*Tests
9 unit tests covering:
to_error_message()field populationlookup_default()consistency