deps(rmcp): migrate 0.16 -> 1.7 (MCP SDK major)#12
Merged
Conversation
rmcp shipped a 0.x->1.x major. The ServerHandler trait signatures
(get_info/list_tools/call_tool), model types (CallToolResult, Content,
CallToolRequestParams, PaginatedRequestParams, ListToolsResult, Tool fields)
and the ServiceExt/stdio entry point are unchanged in 1.7, so main.rs,
error.rs and all tool modules compile as-is.
The one breaking change that touched code: Tool, Implementation and
ServerInfo (= InitializeResult) are now #[non_exhaustive], so struct-literal
construction from this crate is rejected. Converted to the 1.x constructors
+ with_* builders:
- Tool { .. } -> Tool::new(name, desc, Arc<JsonObject>)
- Implementation { .. } -> Implementation::new(name, version).with_*()
- ServerInfo { .. } -> InitializeResult::new(caps).with_*()
schemars kept at 1.x (rmcp 1.7 uses it). cargo check + cargo test --workspace
green (6/6 core tests). stdio initialize + tools/list handshake verified
(36 tools enumerate).
There was a problem hiding this comment.
Pull request overview
Upgrades the MCP Rust SDK dependency (rmcp) from 0.16 to 1.7 and updates server wiring to comply with newly #[non_exhaustive] model types, keeping the server on the manual ServerHandler implementation path.
Changes:
- Bump
rmcpworkspace dependency to1.7. - Update
Tool,Implementation, andServerInfoconstruction inserver.rsto use 1.x constructors/builders. - Refresh
Cargo.lockto reflect the new dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/linux-mcp/src/server.rs | Switches to Tool::new and ServerInfo/Implementation builder-style construction required by rmcp 1.x non-exhaustive types. |
| Cargo.toml | Updates workspace rmcp version requirement to 1.7. |
| Cargo.lock | Locks updated rmcp/rmcp-macros versions and transitive dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [workspace.dependencies] | ||
| rmcp = { version = "0.16", features = ["server", "transport-io", "macros"] } | ||
| rmcp = { version = "1.7", features = ["server", "transport-io", "macros"] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the deps/sweep PR (#11). rmcp 0.16->1.7 — the macro/trait major. This server uses the manual
ServerHandlertrait (not#[tool]macros), so the only code change is 3 now-#[non_exhaustive]structs (Tool/Implementation/ServerInfo) switched to the 1.x builder constructors in server.rs. schemars stays 1.x.cargo check+ 6/6 tests green; stdio handshake enumerates all 36 tools.🤖 Generated with Claude Code