Skip to content

Removing redundant logging from handlers #18

Merged
MichaelBoegner merged 2 commits intomainfrom
fix/remove-handler-logger
Oct 2, 2025
Merged

Removing redundant logging from handlers #18
MichaelBoegner merged 2 commits intomainfrom
fix/remove-handler-logger

Conversation

@MichaelBoegner
Copy link
Owner

No description provided.

@MichaelBoegner MichaelBoegner requested a review from Copilot October 2, 2025 06:55
@MichaelBoegner MichaelBoegner self-assigned this Oct 2, 2025
@MichaelBoegner MichaelBoegner added the fix Fix for broken feature or test label Oct 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant logging from handler functions by eliminating the logger dependency and all associated log statements. The handlers will rely on middleware or other centralized logging mechanisms instead of instance-level logging.

  • Removed logger parameter from Handler struct and NewHandler constructor
  • Eliminated all h.Logger.Error() and h.Logger.Info() calls throughout handlers
  • Updated GetPathID helper function to remove logger parameter

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
handlers/model.go Removed Logger field from Handler struct and logger parameter from NewHandler constructor
handlers/helpers.go Removed logger parameter from GetPathID function and associated logging statements
handlers/handlers.go Removed all h.Logger calls and updated GetPathID function calls
internal/server/server.go Updated NewHandler call to remove logger parameter
internal/testutil/server.go Updated NewHandler call to remove logger parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MichaelBoegner MichaelBoegner merged commit 47ae0c1 into main Oct 2, 2025
1 check passed
@MichaelBoegner MichaelBoegner deleted the fix/remove-handler-logger branch October 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix for broken feature or test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants