Removing redundant logging from handlers #18
Merged
MichaelBoegner merged 2 commits intomainfrom Oct 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant logging from handler functions by eliminating the logger dependency and all associated log statements. The handlers will rely on middleware or other centralized logging mechanisms instead of instance-level logging.
- Removed logger parameter from Handler struct and NewHandler constructor
- Eliminated all h.Logger.Error() and h.Logger.Info() calls throughout handlers
- Updated GetPathID helper function to remove logger parameter
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| handlers/model.go | Removed Logger field from Handler struct and logger parameter from NewHandler constructor |
| handlers/helpers.go | Removed logger parameter from GetPathID function and associated logging statements |
| handlers/handlers.go | Removed all h.Logger calls and updated GetPathID function calls |
| internal/server/server.go | Updated NewHandler call to remove logger parameter |
| internal/testutil/server.go | Updated NewHandler call to remove logger parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.