[ci-test] PR-F SESSION_COOKIE_DOMAIN — fork CI sandbox#3
Closed
MichaelUray wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
…n OIDC koa-session defaults the cookie domain to the request host. OIDC flows that start on one subdomain (dev.example.com) and get the callback on another (app.example.com, the host registered with the IdP) lose the Passport state — the cookie set on dev isn't sent to app, so the callback handler errors with 'did not find expected authorization request details in session'. SESSION_COOKIE_DOMAIN=.example.com scopes the cookie to the parent domain so both subdomains share it. Empty / unset preserves the prior behaviour for setups that only use a single host. Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
Owner
Author
|
CI sandbox complete. Upstream PR opened: hcengineering#10929 |
MichaelUray
pushed a commit
that referenced
this pull request
Jul 9, 2026
Fix Uptrace normalizeMarkdown errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal CI testing. Single-commit fix in pods/authProviders/src/index.ts.