Skip to content

fix: correct n-grams encoding #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvigilv merged 1 commit into from
Jan 21, 2026
Merged

fix: correct n-grams encoding #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/encoding.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,13 +437,15 @@ and shift operations.
# References

- [Torchhd documentation](https://torchhd.readthedocs.io/en/stable/generated/torchhd.ngrams.html)

"""
function ngrams(vs::AbstractVector{<:AbstractHV}, n::Int = 3)
l = length(vs)
p = l - n + 1
@assert 1 <= n <= length(vs) "`n` must be 1 ≤ n ≤ $l"
return bundle([bind([shift(vs[i + j], j) for j in 0:(n - 1)]) for i in 1:p])
return map(
s -> bindsequence(s),
(vs[f:(f + (n - 1))] for f in 1:p)
) |> multiset
end

"""
Expand Down
3 changes: 2 additions & 1 deletion test/encoding.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
end

@testset "ngrams" begin
@test ngrams(hvs) == Bool.([0, 1, 0, 0, 1])
@test ngrams(hvs).v == Bool.([0, 1, 0, 0, 1])
@test ngrams(hvs) == bundle([hvs[1] * ρ(hvs[2]) * ρ(hvs[3], 2), hvs[2] * ρ(hvs[3]) * ρ(hvs[4], 2), hvs[3] * ρ(hvs[4]) * ρ(hvs[5], 2)])
@test_throws AssertionError ngrams(hvs, 0)
@test_throws AssertionError ngrams(hvs, length(hvs) + 1)
end
Expand Down