Skip to content

[nightshift] code-quality: error wrapping, godoc, swallowed error fix#29

Closed
nightshift-micr wants to merge 1 commit into
Microck:mainfrom
nightshift-micr:nightshift/code-quality
Closed

[nightshift] code-quality: error wrapping, godoc, swallowed error fix#29
nightshift-micr wants to merge 1 commit into
Microck:mainfrom
nightshift-micr:nightshift/code-quality

Conversation

@nightshift-micr

Copy link
Copy Markdown
Contributor

Automated by Nightshift v3 (GLM 5.1).

Task: code-quality
Category: pr
Changes:

  • Error wrapping: 17+ bare error returns wrapped with fmt.Errorf context in workflow.go and cli.go
  • Fixed swallowed json.Unmarshal error in cleanupRecord (now logs parse errors)
  • Fixed context.WithTimeout defer placement for proper resource management
  • Standardized CLI error output from fmt.Fprintln to fmt.Fprintf
  • Added godoc comments to 20+ exported types and functions across app/crypto/gui packages
  • Replaced static fmt.Errorf with errors.New for non-formatted messages

Merge if useful, close if not.

@Microck Microck added the dayshift/pr-inbox Managed by hermes-dayshift-glm label Apr 25, 2026
@Microck

Microck commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Closing in favor of #43 and existing mainline fixes. This PR is broad generated churn, stale, and previously had failing checks.

@Microck Microck closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dayshift/pr-inbox Managed by hermes-dayshift-glm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants