Install and use @babel/eslint-parser instead of outdated babel-eslint#128
Open
victorlin wants to merge 2 commits intoMicrosoftDocs:mainfrom
Open
Install and use @babel/eslint-parser instead of outdated babel-eslint#128victorlin wants to merge 2 commits intoMicrosoftDocs:mainfrom
@babel/eslint-parser instead of outdated babel-eslint#128victorlin wants to merge 2 commits intoMicrosoftDocs:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
sbonds
pushed a commit
to sbonds/microsoft-mslearn-staticwebapp
that referenced
this pull request
May 22, 2023
|
this should be merged |
Contributor
|
@victorlin the apps have all recently been updated with the latest package versions, include eslint which is now causing conflicts with this update. If you are able to get that resolved this would be a great change to get merged |
Not sure why babel-eslint was used when it was missing from package-lock. Use the newer NPM package¹, which is already installed by another dependency. ¹ https://www.npmjs.com/package/babel-eslint
Although @babel/eslint-parser is a nested dependency through react-scripts → eslint-config-react-app → @babel/eslint-parser, it is explicitly referenced in this project so it should be included as a direct dependency.
victorlin
force-pushed
the
fix-react-app-eslint
branch
from
f9e14d1 to
6d63904
Compare
Author
|
@saragibby Done. I rebased onto latest from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #127.