Fix UserId format in daily trigger C++ example#2170
Open
1r0BIT wants to merge 1 commit into
Open
Conversation
Replace CREDUI_FLAGS_GENERIC_CREDENTIALS with CREDUI_FLAGS_COMPLETE_USERNAME to enable syntax checking on the supplied username. Set target name to "." (local machine) so bare names like "Administrator" are auto-completed to ".\Administrator", consistent with the principal name formats documented in MS-TSCH §2.5.6. Without this fix, the credential dialog accepts any string without validation, producing potentially ambiguous UserId values in the resulting task XML.
Contributor
|
@1r0BIT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
1r0BIT
changed the title
stevewhims
approved these changes
Mar 19, 2026
Member
|
I don't have perms to complete this. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace CREDUI_FLAGS_GENERIC_CREDENTIALS with
CREDUI_FLAGS_COMPLETE_USERNAME to enable syntax checking on the supplied username to stay consistent with the principal name formats documented in MS-TSCH §2.5.6.
Without this fix, the credential dialog accepts any string without validation, producing potentially ambiguous UserId values in the resulting task XML.