Fix parameter in sample calls to BCryptSetProperty#2177
Open
jonproch117 wants to merge 1 commit into
Open
Conversation
&hKeyPair was being passed instead of hKeyPair, resulting in a failure with STATUS_INVALID_HANDLE when attempting to run the sample code
Contributor
|
@jonproch117 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the ML-DSA CNG documentation samples by passing the correct key handle to BCryptSetProperty, preventing STATUS_INVALID_HANDLE when running the sample code.
Changes:
- Update the
BCryptSetPropertycall in the step-by-step snippet to passhKeyPair(not&hKeyPair). - Update the same
BCryptSetPropertycall in the fullMLDSASignSample()listing to passhKeyPair(not&hKeyPair).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&hKeyPair was being passed instead of hKeyPair, resulting in a failure with STATUS_INVALID_HANDLE when attempting to run the sample code