Feat: Add Support for schemars#25
Open
cappuccinocosmico wants to merge 3 commits intoMidasLamb:masterfrom
Open
Feat: Add Support for schemars#25cappuccinocosmico wants to merge 3 commits intoMidasLamb:masterfrom
cappuccinocosmico wants to merge 3 commits intoMidasLamb:masterfrom
Conversation
0069ca5 to
d970082
Compare
Owner
|
Since, according to your commits, there seems to be a split in which version is used, I think it's a good idea to call the features according to the version, so for supporting of 0.9, the feature flag is |
Author
|
Awesome, I think that's a great way to handle it and just made the changes. My apologies for the delay, my GitHub notifications were turned off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I needed schemars support for some API documentation, and thought I should throw this back. Its totally optional if you dont want to merge it.