Added an option to choose between query contains word and query startsWith#169
Closed
Nielssg wants to merge 1 commit intoMiguelCatalan:developfrom
Nielssg:develop
Closed
Added an option to choose between query contains word and query startsWith#169Nielssg wants to merge 1 commit intoMiguelCatalan:developfrom Nielssg:develop
Nielssg wants to merge 1 commit intoMiguelCatalan:developfrom
Nielssg:develop
Conversation
|
@MiguelCatalan, please review and accept this and other pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For many purposes, the query can start with characters that are not filled in by the user.
Example:
Let's say a user wants to search Mr. Smith. When the user types Smith, there will be no result as the default way is to check if the suggestion startsWith the query, which in this case is Mr. Smith.
To let developers choose between contains and startsWith, I created an extra constructor where you can pass a boolean whether to use contains or startWith. The boolean will be used in the filtering method to decide if the string should be checked with contains or startsWith.
There is a similar pull request (#127), but as this is more customizable for the developer, I decided to create a new pull request