fix: upgrade release action to v2 to fix asset upload failure#38
Merged
fix: upgrade release action to v2 to fix asset upload failure#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
softprops/action-gh-release@v1has a race condition: it creates and publishes the release immediately, then tries to upload assets in parallel. This causes 422Cannot upload assets to an immutable releaseerrors for all but the first uploaded file.Fix
Upgrade to
softprops/action-gh-release@v2which handles atomic upload before publishing correctly.Affected releases
v0.4.3 and v0.5.0 both have empty release assets due to this bug.