fix: exclude PDB files from release artifacts and installer (closes #39)#41
Merged
fix: exclude PDB files from release artifacts and installer (closes #39)#41
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b178633 to
c164f92
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #39 by preventing .pdb debug symbol files from being included in end-user release artifacts (zip packages and the Inno Setup installer), adding multiple safeguards across the build, packaging, and installer layers.
Changes:
- Disable PDB generation for Release builds in the app
.csproj. - Exclude
*.pdbfrom the Inno Setup installer file collection. - Add a GitHub Actions workflow step to delete any remaining
.pdbfiles from publish outputs before packaging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/HomeAssistantWindowsVolumeSync.csproj |
Disables PDB generation in Release configuration to avoid producing symbol files for publish/artifacts. |
installer/windows.iss |
Excludes *.pdb from installer inputs as a packaging-time safeguard. |
.github/workflows/release.yml |
Removes any .pdb files from publish directories prior to creating zip artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #39.
PDB debug symbol files were being included in release artifacts. Three layers of defence added:
1.
src/HomeAssistantWindowsVolumeSync.csprojAdded
<DebugType>none</DebugType>and<DebugSymbols>false</DebugSymbols>to the ReleasePropertyGroup. PDBs are never generated at publish time.2.
installer/windows.issAdded
Excludes: "*.pdb"to the[Files]entry. Belt-and-suspenders for the installer.3.
.github/workflows/release.ymlAdded a "Remove PDB files from publish output" step before zip creation. Recursively deletes any
.pdbfiles from both publish directories as a final safety net.