Skip to content

fix: exclude PDB files from release artifacts and installer (closes #39)#41

Merged
KrennicMS merged 2 commits intodevelopfrom
fix/exclude-pdb-from-release
Mar 19, 2026
Merged

fix: exclude PDB files from release artifacts and installer (closes #39)#41
KrennicMS merged 2 commits intodevelopfrom
fix/exclude-pdb-from-release

Conversation

@KrennicMS
Copy link
Copy Markdown
Collaborator

Summary

Closes #39.

PDB debug symbol files were being included in release artifacts. Three layers of defence added:

1. src/HomeAssistantWindowsVolumeSync.csproj

Added <DebugType>none</DebugType> and <DebugSymbols>false</DebugSymbols> to the Release PropertyGroup. PDBs are never generated at publish time.

2. installer/windows.iss

Added Excludes: "*.pdb" to the [Files] entry. Belt-and-suspenders for the installer.

3. .github/workflows/release.yml

Added a "Remove PDB files from publish output" step before zip creation. Recursively deletes any .pdb files from both publish directories as a final safety net.

@MiguelTVMS MiguelTVMS requested a review from Copilot March 19, 2026 10:43

This comment was marked as resolved.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@KrennicMS KrennicMS force-pushed the fix/exclude-pdb-from-release branch from b178633 to c164f92 Compare March 19, 2026 10:48
@MiguelTVMS MiguelTVMS requested a review from Copilot March 19, 2026 10:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #39 by preventing .pdb debug symbol files from being included in end-user release artifacts (zip packages and the Inno Setup installer), adding multiple safeguards across the build, packaging, and installer layers.

Changes:

  • Disable PDB generation for Release builds in the app .csproj.
  • Exclude *.pdb from the Inno Setup installer file collection.
  • Add a GitHub Actions workflow step to delete any remaining .pdb files from publish outputs before packaging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/HomeAssistantWindowsVolumeSync.csproj Disables PDB generation in Release configuration to avoid producing symbol files for publish/artifacts.
installer/windows.iss Excludes *.pdb from installer inputs as a packaging-time safeguard.
.github/workflows/release.yml Removes any .pdb files from publish directories prior to creating zip artifacts.

@KrennicMS KrennicMS merged commit 45d8fbf into develop Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants