Add handling to check a user's plugSets if collectibleHash is missing (for emotes)#2
Open
FlaminSarge wants to merge 4 commits intoMijago:masterfrom
Open
Add handling to check a user's plugSets if collectibleHash is missing (for emotes)#2FlaminSarge wants to merge 4 commits intoMijago:masterfrom
FlaminSarge wants to merge 4 commits intoMijago:masterfrom
Conversation
FlaminSarge
changed the title
…iding setting state if no new info found
…ollectibles, for good measure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for the sole universal-code emote to show up as collected properly instead of always showing up without an acquired/unacquired status.
Based on the docs in https://github.com/Bungie-net/api/wiki/2.2.0-API-Changes, https://bungie-net.github.io/#/components/schemas/Destiny.Sockets.DestinyItemPlugBase, and my own testing with the components=305 query.
Tested across multiple accounts with different states.