fix: make popup window key window when presenting popup#203
Open
videni wants to merge 1 commit intoMijick:mainfrom
Open
fix: make popup window key window when presenting popup#203videni wants to merge 1 commit intoMijick:mainfrom
videni wants to merge 1 commit intoMijick:mainfrom
Conversation
When using PopupSceneDelegate, TextField inside popups cannot receive keyboard focus because clicking the button to present a popup makes the main window the key window. Changes: - Renamed internal Window class to MijickWindow for reliable identification - After present() completes, find MijickWindow by class name and call makeKey()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201
Problem
When using
PopupSceneDelegate, TextField inside popups cannot receive keyboard focus because clicking the button to present a popup makes the main window the key window.Solution
Windowclass toMijickWindowfor reliable identificationpresent()completes, findMijickWindowby class name and callmakeKey()Changes
Public+Setup+SceneDelegate.swift: RenamedWindowtoMijickWindowPublic+Present+Popup.swift: AddedmakePopupWindowKey()toPopup.present()method