Skip to content

fix: Fixed the bug that prevented the correct identification of upnp …#157

Open
Droid-MAX wants to merge 3 commits intoMikeWang000000:devfrom
Droid-MAX:master
Open

fix: Fixed the bug that prevented the correct identification of upnp …#157
Droid-MAX wants to merge 3 commits intoMikeWang000000:devfrom
Droid-MAX:master

Conversation

@Droid-MAX
Copy link

…devices

@MikeWang000000 MikeWang000000 changed the base branch from master to dev October 27, 2025 12:28
Copy link
Owner

@MikeWang000000 MikeWang000000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! As we need to merge all PRs into dev branch before going to master, please change the base branch to dev and solve the merge conflicts.

@Droid-MAX
Copy link
Author

I think that in most legal response fields, apart from the two headers "LOCATION" and "Location", other situations basically do not occur, and in the response body, only lowercase http protocol headers will basically appear.

Droid-MAX and others added 2 commits October 27, 2025 21:14
Co-authored-by: Mike Wang <mikewang000000@gmail.com>
@MikeWang000000
Copy link
Owner

apart from the two headers "LOCATION" and "Location"

Even Location is not common in SSDP messages. All header names in UPnP Device Architecture 1.0 is all-uppercase (e.g. LOCATION, not Location). It specifies All header values are case sensitive except where noted without mentioning header names. Tough the later one v2.0 additionally clarifies that the header name is case-insensitive, many implementations like miniupnp still uses the all-uppercase form.

But when we decide to fix this rare case, we should also take other corner cases into consideration as well. Functions like split_url() should also be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants