Skip to content

Require a branch + PR for all changes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeWills merged 1 commit into from
Jul 15, 2026
Merged

Require a branch + PR for all changes #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@ All filters are query parameters to `api.weather.gov`. Do **not** pull all alert
- `LogError` — failures (API errors, exceptions)
- Platform name as first token: `"Facebook: Post failed. Status={Status}"`

### 8. Always work on a branch and open a pull request — never push directly to `master`

Even for a single small fix. Create a feature branch, commit there, push it, and open a PR with
`gh pr create` — then stop and let the human merge it (or explicitly ask before merging). Do not
push straight to `master`, and do not merge a PR yourself unless explicitly told to. `master`'s
branch protection allows this repo's owner to bypass its required "test" status check, but
bypassing it skips CI entirely — a PR is what actually runs `dotnet test` before anything lands.

Comment on lines +159 to +162

@claude claude Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factual inaccuracy: "bypassing it skips CI entirely" isn't accurate for this repo. .github/workflows/deploy.yml triggers on every push to master and has its own dotnet test step (a deploy-time safety net), and .github/workflows/ci.yml's test job also triggers on push: branches: [master] in addition to pull_request. So a direct push to master still runs dotnet test in both workflows — it just isn't gated before the push lands. The rationale here would be more accurate as something like "bypassing it skips the pre-merge gate — tests still run post-push in deploy.yml/ci.yml, but a broken change can already be on master by the time they fail."

NwsAlertBot/CLAUDE.md

Lines 159 to 162 in 29a2cc5

push straight to `master`, and do not merge a PR yourself unless explicitly told to. `master`'s
branch protection allows this repo's owner to bypass its required "test" status check, but
bypassing it skips CI entirely — a PR is what actually runs `dotnet test` before anything lands.

---

## Key External APIs
Expand Down
Loading