fix: stop masking non-request errors and accept JSON arrays as data#97
Merged
Merged
Conversation
MikeWooster
commented
Jun 7, 2026
MikeWooster
commented
Owner
- narrow request strategy error handling to requests.RequestException so unrelated errors propagate instead of being reported as UnexpectedError (Don't swallow errors #80)
- widen the data argument on post/put/patch to the existing JsonType alias, so arrays are accepted by type checkers (post() does not support arrays #90)
- repair two cassette responses using the legacy 'body: null' serialization that current vcrpy cannot replay; the get_user retry test now exercises a real 500 response instead of a masked vcr error
- narrow request strategy error handling to requests.RequestException so unrelated errors propagate instead of being reported as UnexpectedError (#80) - widen the data argument on post/put/patch to the existing JsonType alias, so arrays are accepted by type checkers (#90) - repair two cassette responses using the legacy 'body: null' serialization that current vcrpy cannot replay; the get_user retry test now exercises a real 500 response instead of a masked vcr error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.