config: movement speed sliders#190
Merged
hashalite merged 4 commits intoMinecraftFreecam:mainfrom Apr 1, 2024
Merged
Conversation
`@BoundedContinuous` is based on autoconfig's `@BoundedDiscrete`, but ported to floating-point values.
MattSturgeon
changed the title
MattSturgeon
commented
Mar 12, 2024
MattSturgeon
commented
Mar 12, 2024
MattSturgeon
commented
Mar 12, 2024
common/src/main/java/net/xolt/freecam/config/gui/BoundedContinuousImpl.java
Show resolved
Hide resolved
MattSturgeon
commented
Mar 18, 2024
MattSturgeon
commented
Mar 18, 2024
Member
Author
|
Would it be worth the extra complexity to have both a text-box and a slider? If so I might tackle that in a follow up PR once this is merged... |
…ntry.java Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
hashalite
approved these changes
Apr 1, 2024
Collaborator
hashalite
left a comment
hashalite
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds slider widgets for horizontal and vertical movement speed.
Introduces a custom
@BoundedScalableannotation andDoubleSliderEntryGUI, based on cloth-config's@BoundedDiscreteandIntegerSliderEntryrespectively.Unlike my earlier implementation in #121, which ported the speed options to
intso it could use cloth-config's@BoundedDiscrete, this implementation will not affect how speed values are stored or saved.The PR is split into two parts; the first commit is a general refactor to allow adding more cloth-config extensions than just
VariantTooltip. The second commit contains the meat of this PR.