fix(commands): use ?? instead of || for numeric flag defaults#42
Merged
RyanLee-Dev merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(commands): use ?? instead of || for numeric flag defaults#42RyanLee-Dev merged 1 commit intomainfrom
RyanLee-Dev merged 1 commit intomainfrom
Conversation
|| treats 0 as falsy, silently replacing explicit zero values with defaults. --max-tokens 0 became 4096, --speed 0 vanished entirely. Affects 5 commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
||with??for all numeric flag defaults across 5 command files||treats0as falsy →--max-tokens 0became 4096,--speed 0vanishedTest plan
--max-tokens 0 --dry-run→ request showsmax_tokens: 0--speed 0 --dry-run→ request showsspeed: 0--n 0 --dry-run→ request showsn: 0🤖 Generated with Claude Code