fix(download): add error handling, backpressure, and flush-wait#44
Merged
RyanLee-Dev merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(download): add error handling, backpressure, and flush-wait#44RyanLee-Dev merged 1 commit intomainfrom
RyanLee-Dev merged 1 commit intomainfrom
Conversation
- Register writer.on('error') to catch disk-full/permission errors
- Check writer.write() return value and await drain for backpressure
- Await writer finish event before returning to prevent truncated files
- Clean up partial files on failure
- Use CLIError instead of plain Error
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writer.on('error')to catch disk-full/permission errors instead of crashingwriter.write()return value and awaitdrainevent to prevent unbounded memory growthwriter.on('finish')before returning to prevent truncated filesCLIErrorinstead of plainErrorfor structured outputTest plan
🤖 Generated with Claude Code