fix(config): validate MINIMAX_TIMEOUT env var to prevent NaN crash#46
Merged
RyanLee-Dev merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(config): validate MINIMAX_TIMEOUT env var to prevent NaN crash#46RyanLee-Dev merged 1 commit intomainfrom
RyanLee-Dev merged 1 commit intomainfrom
Conversation
Non-numeric values like "abc" produced NaN → AbortSignal.timeout(NaN) threw TypeError. Now invalid values are silently ignored with fallback to 300s. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MINIMAX_TIMEOUTenv var: reject NaN, negative, and non-finite valuesMINIMAX_TIMEOUT=abccausedAbortSignal.timeout(NaN)→ TypeError crashTest plan
MINIMAX_TIMEOUT=abc minimax text chat --message "hi"→ no crash, uses 300s defaultMINIMAX_TIMEOUT=30 minimax text chat --message "hi"→ uses 30s timeout🤖 Generated with Claude Code