Add START_TIMEOUT#688
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 91.96% 92.01% +0.05%
==========================================
Files 9 9
Lines 1107 1114 +7
==========================================
+ Hits 1018 1025 +7
Misses 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERRORlog when a container with a restart policy takes a moment to reachrunningstate after backup — downgraded toWARNsince the backup completes successfullyINFO: Container X is now running.confirmation log when a container eventually stabilizes after retriesSTART_TIMEOUTenvironment variable (default:10seconds) controlling how long Nautical waits for a container to reach running state, checking every 2 secondsnautical-backup.start-timeoutlabel to overrideSTART_TIMEOUTfor individual containersBefore / After
Before (v2.20.0):
After:
New options
START_TIMEOUT=10nautical-backup.start-timeout=10START_TIMEOUTTest plan
restartingstates beforerunning(reproduces issue Container running state error. #683)start-timeoutlabel overrides globalSTART_TIMEOUTenv var