DEVOPS-977: default zizmor config to allow MiraGeoscience unpinned actions#152
DEVOPS-977: default zizmor config to allow MiraGeoscience unpinned actions#152andrewg-mira wants to merge 3 commits intomainfrom
Conversation
sebhmg
left a comment
There was a problem hiding this comment.
see suggestion for merging config with existing zizmor file
db4880f to
d4c4c18
Compare
There was a problem hiding this comment.
Pull request overview
Updates the reusable Zizmor workflows and the Zizmor config setup action so CI can allow trusted, tag-pinned MiraGeoscience GitHub Actions while still running Zizmor scans.
Changes:
- Bump
setup-zizmor-configaction reference in reusable Zizmor workflows fromv2tov3.1. - Change the
setup-zizmor-configcomposite action to create/patchzizmor.ymlviayq. - Add an
unpinned-usespolicy forMiraGeoscience/*withref-pinin the generated/updated config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/reusable-zizmor-security.yml | Updates the setup-zizmor-config action ref to v3.1 before running Zizmor. |
| .github/workflows/reusable-zizmor-annotate.yml | Updates the setup-zizmor-config action ref to v3.1 before running Zizmor with annotations. |
| .github/actions/setup-zizmor-config/action.yml | Switches from creating a static config to patching/merging config via yq, adding the new policy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # Patch (merge) with extra config | ||
| echo "Patching zizmor.yml configuration file for CI..." |
There was a problem hiding this comment.
suggestion: just change description to
Ensures zizmor.yml exists and patches CI-specific Zizmor rules
| - name: Setup Zizmor Config | ||
| uses: MiraGeoscience/CI-tools/.github/actions/setup-zizmor-config@v2 | ||
| uses: MiraGeoscience/CI-tools/.github/actions/setup-zizmor-config@v3.1 | ||
|
|
There was a problem hiding this comment.
suggestion: tag v3.1 and move all actions to use v3.1 instead of v2
| - name: Setup Zizmor Config | ||
| uses: MiraGeoscience/CI-tools/.github/actions/setup-zizmor-config@v2 | ||
| uses: MiraGeoscience/CI-tools/.github/actions/setup-zizmor-config@v3.1 | ||
|
|
DEVOPS-977 - Zizmor: Allow trusted tag-pinned github actions