Skip to content

DEVOPS-989: use reusable pr_jira_actions workflow#854

Closed
andrewg-mira wants to merge 224 commits intomainfrom
DEVOPS-989-github-PR-action
Closed

DEVOPS-989: use reusable pr_jira_actions workflow#854
andrewg-mira wants to merge 224 commits intomainfrom
DEVOPS-989-github-PR-action

Conversation

@andrewg-mira
Copy link
Contributor

@andrewg-mira andrewg-mira commented Mar 10, 2026

DEVOPS-989 - Migrate repositories to use Jira actions github workflow

  • match the disabled skipping behaviour of to_params in the validate_data to avoid key error.
  • repr is just the path (or title if path isn't set) and str is the json formatted string
  • pylint fix
  • create the workspace
  • Docstring typing upgrade
  • add to_params call to test_disabled_forms and check disabled form values are omitted
  • Add flatten method and hook up to_params. Tests passing
  • decided not to use flatten in the print, adjusted the formatting a bit and allowing str with conversion on read(path) for convenience.
  • Dynamically create a StrEnum from the DataTypeEnum in geoh5py.Data
  • User DataAssociationEnum in dynamic strEnum
  • first pass
  • Add multi choice data form, split data form into plain and data or value form types to reduce complexity
  • Add a data group form (used for gradient rotation in simpeg-drivers ui.json)
  • Fix infinite recursion bug when BaseUIJson.read() takes a file with a parameter named 'groups'.
  • MultiChoiceDataForm->MultiSelectDataForm
  • add place_holder_text
  • Access class attribute model_fields
  • Bump pydantic
  • Bring back geoh5 promotion
  • Augment unit test
  • first draft.
  • functions are working and cleanup.
  • I had to remove the auto-creation of a 2dgrid for tif, because it's obviously create errors for large image!
  • fiiiixed!
  • added Dom's comments
  • small changes for tests to pass
  • fix name so that camel to snake conversion is handled properly by pydantic
  • update docstring too
  • Bump urllib3 from 2.5.0 to 2.6.0
  • add an extra test file for errors in cut_by_extent (mechanics tested under geoimage)
  • First pass
  • annotations and validations in the right homes
  • more Ben,s comments
  • las tchanges. correcting the tests
  • poetry update
  • Add DataRangeForm to the infer
  • small refactor while looking into fixtures for Matthieu. We can call a fixture from within a fixture, so I replaced the old mechanic of passing tmp_path into a function that creates data with a fixture (tmp_path) in a fixture (sample_uijson).
  • Updated docstrings/typing across forms/uijson
  • Remove code associated with aborted uijson/forms design and subclasses of BaseValidationError intended to be used by InputFile, but currently not being used.
  • Add curly braces to uid serializers
  • fix test
  • fisrt round.
  • augment the guardrails
  • Matthieu's comments
  • clean out tests
  • added the tests
  • fix the visual parameter bug
  • modifications from Ben's comments
  • update annotation and log inferred types
  • remove print
  • happy new year!
  • always set the transparency if not present
  • change the function to define the plane from 2 points
  • dom's comment:
  • [pre-commit.ci] auto fixes from pre-commit.com hooks
  • linter fix
  • Fix up copyright years
  • update based on dom's comment:
  • last copyrights to change
  • Make u,v_cell_size kwargs
  • first pass
  • Replaced infer with logic stored in forms under abc enforced type_check method.
  • linter fix
  • Use generic type var to remove type_check assert after all_subclasses
  • Update geoh5py/ui_json/forms.py
  • remove double if statements in favour of 'and' logic and remove return check in favor of double return statements.
  • New infer without type_check and indicator_keys
  • cleanup
  • linter
  • linter
  • simplification
  • dedicated form_utils
  • only compute all_subclasses and indicator_attributes once
  • Add utility method on curve object
  • cleanup
  • Fix error message
  • Flip colors in and out, update test
  • Fix docs. Add image
  • Open/close workspace between exmaples
  • Dom's comments
  • remove typevar
  • Further simplification
  • Add comment
  • Add docs about child/parent relationship
  • Use TypeAdaptor for type checking
  • update str to show form types for easier validation of infer method
  • code quality fix
  • Fix typo. Expand on parent re-assignment
  • Minor clean ups
  • More typos
  • Fix typo and improve layout
  • Use dictionary to map GA names to geoh5py class names
  • case and whitespace insensitivity
  • Refactor FileForm -> FileForm, MultiFileForm, DirectoryForm.
  • Start adding Maxwell plate with geometry from viz params
  • Dom's comments
  • Fix serialization of parameters
  • fix for ubuntu pytest runs
  • Use ContextVar to pass the parent to child model. Being adding tests
  • Update geoh5py/ui_json/forms.py
  • Pass the parent during validation instead of ContextVar
  • Finish implementation. Change set_tag on visualparameters to handle dict of values.
  • Add classes
  • More docstrings
  • Beef up unit test
  • Use deep copy instead of copy
  • Remove class attributes
  • Add unit test
  • update the GA_STRING_TO_GROUP/OBJECT mappers.
  • Add return type
  • Implement kwargs instead
  • Remove type ignore
  • Fix test
  • Mute pylint
  • update all _default_name class attributes and generate map for pydantic validation
  • replace TYPE_UID_TO_CLASS definition with call to map_to_class
  • Update geoh5py/objects/surveys/electromagnetics/base.py
  • Update geoh5py/objects/surveys/electromagnetics/base.py
  • Update geoh5py/shared/utils.py
  • Update geoh5py/shared/validators.py
  • Update geoh5py/shared/validators.py
  • finish GA_STRING -> GA_NAME rename
  • add PyCharm iml for scope definition to work
  • Decrease the odds
  • Bump versions
  • Bump gitactions
  • Update tests
  • Remove randomness in length
  • Re-lock numpy on 2.4.2
  • Update recipe
  • Attempt fix for linux
  • Line up recipe
  • DEVOPS-977 zizmor: allow unpinned action from MiraGeoscience repos
  • [GEOPY-2661] simplify dependency version expression
  • [GEOPY-2661] no need of h5py in dev deps, as already a main one
  • [GEOPY-2661] use python_min variable instead of hard-coded python version
  • add Dom as a recipe maintainer
  • [GEOPY-2661] remove reference to obsolete numpy plugin for mypy
  • [GEOPY-2661] modernize code for Python 3.12
  • [GEOPY-2661] stronger typehints
  • fix swapped zizmor job names
  • change the typing of depth_table_by_name
  • DEVOPS-989 use reusable pr_jira_actions workflow

benk-mira and others added 30 commits November 4, 2025 11:41
GEOPY-2495: Better string conversion of UIJSon class used by print
GEOPY-2499: BaseUIJson crashes in to_params validation when skipping over disabled fields.
…t and allowing str with conversion on read(path) for convenience.
GEOPY-2488: UIJson should have a flatten method to retrieve value/property of all forms
GEOPY-2506: Support all data associations in DataForm
# Conflicts:
#	geoh5py/ui_json/forms.py
#	geoh5py/ui_json/ui_json.py
domfournier and others added 25 commits February 12, 2026 10:57
GEOPY-2700: Random failure of name incrementor test
GEOPY-2661: Update minimum requirement to python >=3.12, <3.15 and numpy 2.*
and point to newer numpy version in pre-commit config
(although it is still commented-out)
# Conflicts:
#	geoh5py/shared/utils.py
#	geoh5py/ui_json/enforcers.py
#	geoh5py/ui_json/parameters.py
#	geoh5py/ui_json/validations/form.py
#	tests/__init__.py
#	tests/add_filename_data_test.py
#	tests/block_model_test.py
#	tests/boolean_test.py
#	tests/color_map_test.py
#	tests/conversion_base_test.py
#	tests/coordinate_system_test.py
#	tests/copy_entity_test.py
#	tests/copy_extent_cell_data_test.py
#	tests/copy_extent_vertex_data_test.py
#	tests/coulour_test.py
#	tests/curve_data_test.py
#	tests/data_instantiation_test.py
#	tests/delete_entity_test.py
#	tests/drape_model_test.py
#	tests/drillhole_data_test.py
#	tests/drillhole_v4_0_test.py
#	tests/entity_attributes_test.py
#	tests/entity_parent_test.py
#	tests/geo_image_test.py
#	tests/geometric_datatype_test.py
#	tests/grid_2d_test.py
#	tests/grid_object_test.py
#	tests/group_test.py
#	tests/groups_instantiation_test.py
#	tests/h5_non_ascii_filename_test.py
#	tests/insert_drillhole_data_test.py
#	tests/interpretation_section_test.py
#	tests/io_utils_test.py
#	tests/io_write_test.py
#	tests/label_test.py
#	tests/merger_curve_test.py
#	tests/merger_drape_model_test.py
#	tests/merger_surface_test.py
#	tests/merger_test.py
#	tests/metadata_test.py
#	tests/modify_property_group_test.py
#	tests/monitored_update_test.py
#	tests/no_data_value_test.py
#	tests/notype_test.py
#	tests/numeric_data_test.py
#	tests/objects_instantiation_test.py
#	tests/octree_test.py
#	tests/point_data_test.py
#	tests/property_group_test.py
#	tests/reference_data_test.py
#	tests/remove_root_test.py
#	tests/save_modified_properties_test.py
#	tests/set_parent_test.py
#	tests/shared_utils_test.py
#	tests/surveys/__init__.py
#	tests/surveys/surface_data_test.py
#	tests/surveys/survey_airborne_tem_test.py
#	tests/surveys/survey_dcip_test.py
#	tests/surveys/survey_fem_test.py
#	tests/surveys/survey_ground_tem_test.py
#	tests/surveys/survey_mt_test.py
#	tests/surveys/survey_tipper_test.py
#	tests/text_data_test.py
#	tests/text_object_test.py
#	tests/ui_json/__init__.py
#	tests/ui_json/enforcers_test.py
#	tests/ui_json/exceptions_test.py
#	tests/ui_json/forms_test.py
#	tests/ui_json/parameter_test.py
#	tests/ui_json/set_dict_test.py
#	tests/ui_json/uijson_test.py
#	tests/ui_json_group_test.py
#	tests/ui_json_test.py
#	tests/ui_json_utils_test.py
#	tests/user_comments_test.py
#	tests/utils_test.py
#	tests/validators_test.py
#	tests/version_test.py
#	tests/vp_mesh_test.py
#	tests/weakref_test.py
#	tests/weakref_utils_test.py
#	tests/workspace_context_test.py
#	tests/workspace_test.py
@github-actions github-actions bot changed the title DEVOPS-989 use reusaale pr_jira_actions workflow DEVOPS-989: use reusaale pr_jira_actions workflow Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 93.40659% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.18%. Comparing base (111470c) to head (da71cd2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
geoh5py/shared/cut_by_extent.py 92.10% 6 Missing and 6 partials ⚠️
geoh5py/ui_json/validations/form.py 59.25% 10 Missing and 1 partial ⚠️
...jects/surveys/electromagnetics/airborne_app_con.py 89.88% 5 Missing and 4 partials ⚠️
geoh5py/objects/geo_image.py 95.75% 4 Missing and 3 partials ⚠️
geoh5py/objects/maxwell_plate.py 93.02% 1 Missing and 5 partials ⚠️
geoh5py/shared/utils.py 92.20% 3 Missing and 3 partials ⚠️
geoh5py/ui_json/forms.py 97.10% 2 Missing and 2 partials ⚠️
geoh5py/objects/object_base.py 66.66% 1 Missing and 1 partial ⚠️
geoh5py/ui_json/ui_json.py 96.61% 1 Missing and 1 partial ⚠️
geoh5py/shared/validators.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   90.91%   91.18%   +0.27%     
==========================================
  Files         113      115       +2     
  Lines        9869    10272     +403     
  Branches     1836     1898      +62     
==========================================
+ Hits         8972     9367     +395     
+ Misses        485      483       -2     
- Partials      412      422      +10     
Files with missing lines Coverage Δ
geoh5py/data/referenced_data.py 83.13% <100.00%> (+0.63%) ⬆️
geoh5py/data/visual_parameters.py 86.84% <100.00%> (+3.50%) ⬆️
geoh5py/groups/__init__.py 100.00% <100.00%> (ø)
geoh5py/groups/container.py 100.00% <100.00%> (ø)
geoh5py/groups/drillhole.py 100.00% <100.00%> (ø)
geoh5py/groups/integrator.py 100.00% <100.00%> (ø)
geoh5py/groups/interpretation_section.py 100.00% <100.00%> (ø)
geoh5py/groups/survey.py 100.00% <100.00%> (ø)
geoh5py/objects/__init__.py 100.00% <100.00%> (ø)
geoh5py/objects/block_model.py 98.41% <100.00%> (+0.02%) ⬆️
... and 39 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewg-mira andrewg-mira changed the title DEVOPS-989: use reusaale pr_jira_actions workflow DEVOPS-989: use reusable pr_jira_actions workflow Mar 11, 2026
@andrewg-mira andrewg-mira deleted the DEVOPS-989-github-PR-action branch March 11, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants