This repository was archived by the owner on Aug 21, 2025. It is now read-only.
GEOPY-2262: Hook up plate simulation to the geoapps_utils.make_plate function#84
Merged
domfournier merged 7 commits intodevelopfrom Jun 25, 2025
Merged
GEOPY-2262: Hook up plate simulation to the geoapps_utils.make_plate function#84domfournier merged 7 commits intodevelopfrom
domfournier merged 7 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #84 +/- ##
===========================================
- Coverage 91.84% 90.83% -1.02%
===========================================
Files 8 8
Lines 466 480 +14
Branches 37 38 +1
===========================================
+ Hits 428 436 +8
- Misses 22 27 +5
- Partials 16 17 +1
🚀 New features to boost your workflow:
|
benk-mira
reviewed
Jun 24, 2025
Contributor
benk-mira
left a comment
There was a problem hiding this comment.
Seems like there's some duplication with geoapps_utils.modelling.plates make_plate.. but it seems intentional - can you explain?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2262 - Hook up plate simulation to the geoapps_utils.make_plate function