GEOPY-2029: Update Simpeg 0.21.2 to 0.23#156
Conversation
github-actions
bot
changed the title
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Weren't there a couple API updates on the simpeg PR? I was expecting some updates to factories..
- scikit-learn is a direct dependency - newer version of geoana - no indirect dependency on pandas - no indirect dependency on empymod
…EOPY-2029-seb # Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # pyproject.toml
|
I cannot make a global environment with pytorch >= 2.5 and mkl 2023 Is there an issue to try and fix expected results with mkl 2024 ? See my comments on test results with mkl 2024 here: #157 (comment) |
The results are nonsensical and not reproducible locally with what gitactions is returning. So definitely don't want to pin our target on this. The target changes by just moving the version of mkl is exactly why we put those tests in place. The versions should not affect the results from the direct solver. I don't know what to tell you. |
we cannot just keep mkl 2023. It needs to update to 2024 because of pytorch... Suggestions:
|
…-drivers into GEOPY-2029 # Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # pyproject.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
+ Coverage 88.95% 89.22% +0.26%
===========================================
Files 77 80 +3
Lines 3940 4482 +542
Branches 547 607 +60
===========================================
+ Hits 3505 3999 +494
- Misses 302 329 +27
- Partials 133 154 +21 |
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.10" | ||
| python = "^3.10, <3.12" # geoana does not support 3.12 yet |
There was a problem hiding this comment.
not true anymore with geoana >0.7.0
3 participants
GEOPY-2029 - Update Simpeg 0.21.2 to 0.23