Skip to content

GEOPY-2025: Duplicated survey object when monitoring_directory is used#165

Merged
domfournier merged 12 commits intodevelopfrom
GEOPY-2025
Mar 7, 2025
Merged

GEOPY-2025: Duplicated survey object when monitoring_directory is used#165
domfournier merged 12 commits intodevelopfrom
GEOPY-2025

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Mar 6, 2025

GEOPY-2025 - Duplicated survey object when monitoring_directory is used

@domfournier domfournier requested a review from benk-mira March 6, 2025 22:22
@github-actions github-actions bot changed the title GEOPY-2025 GEOPY-2025: Duplicated survey object when monitoring_directory is used Mar 6, 2025
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (82f9801) to head (bf2c1fe).
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
+ Coverage    89.52%   89.60%   +0.07%     
===========================================
  Files           81       81              
  Lines         4603     4597       -6     
  Branches       607      606       -1     
===========================================
- Hits          4121     4119       -2     
+ Misses         329      323       -6     
- Partials       153      155       +2     
Files with missing lines Coverage Δ
...drivers/components/factories/directives_factory.py 96.52% <ø> (ø)
...peg_drivers/components/factories/entity_factory.py 77.02% <100.00%> (-1.73%) ⬇️
...drivers/components/factories/simulation_factory.py 98.01% <100.00%> (ø)
simpeg_drivers/utils/testing.py 85.48% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bring back the test_gravity_uijson or is it not working?

benk-mira
benk-mira previously approved these changes Mar 7, 2025
@domfournier domfournier merged commit 8365c00 into develop Mar 7, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2025 branch March 7, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants