Skip to content

GEOPY-2068: Clean up pydantic warnings#173

Merged
domfournier merged 17 commits intodevelopfrom
GEOPY-2068
Mar 21, 2025
Merged

GEOPY-2068: Clean up pydantic warnings#173
domfournier merged 17 commits intodevelopfrom
GEOPY-2068

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Mar 17, 2025

GEOPY-2068 - Clean up pydantic warnings

@github-actions github-actions bot changed the title Geopy 2068 GEOPY-2068: Clean up pydantic warnings Mar 17, 2025
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 95.89744% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (2834ca2) to head (74a47c5).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/joint/params.py 91.01% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
+ Coverage    89.60%   89.62%   +0.02%     
===========================================
  Files           81       81              
  Lines         4599     4685      +86     
  Branches       606      608       +2     
===========================================
+ Hits          4121     4199      +78     
- Misses         323      328       +5     
- Partials       155      158       +3     
Files with missing lines Coverage Δ
...drivers/components/factories/directives_factory.py 96.52% <ø> (ø)
...epth_of_investigation/sensitivity_cutoff/params.py 91.66% <100.00%> (ø)
simpeg_drivers/driver.py 87.91% <100.00%> (-0.04%) ⬇️
...s/direct_current/pseudo_three_dimensions/params.py 100.00% <100.00%> (ø)
...ctricals/direct_current/three_dimensions/params.py 100.00% <100.00%> (ø)
...lectricals/direct_current/two_dimensions/params.py 100.00% <100.00%> (ø)
...ced_polarization/pseudo_three_dimensions/params.py 100.00% <100.00%> (ø)
...ls/induced_polarization/three_dimensions/params.py 100.00% <100.00%> (ø)
...cals/induced_polarization/two_dimensions/params.py 100.00% <100.00%> (ø)
...rivers/electromagnetics/frequency_domain/params.py 82.14% <100.00%> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, lots of fixes from those warnings. See comments.

Copy link
Collaborator

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be finalized on GEOPY-2046

@domfournier domfournier merged commit b69d1b0 into develop Mar 21, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2068 branch March 21, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants