GEOPY-95: Migrate em_inversion (EM1D) script to simpeg-drivers#174
Merged
domfournier merged 35 commits intodevelopfrom Mar 31, 2025
Merged
GEOPY-95: Migrate em_inversion (EM1D) script to simpeg-drivers#174domfournier merged 35 commits intodevelopfrom
domfournier merged 35 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
benk-mira
reviewed
Mar 21, 2025
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
some ui.json suggestions to make the new one compatible with my changes on 2068
| "verbose": 2, | ||
| "enabled": true, | ||
| "tooltip": "Set the number of iterations per beta value. Use higher values for more non-linear optimization problems." | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| }, | |
| }, | |
| "epsilon_cooling_factor": 1.2, |
Contributor
There was a problem hiding this comment.
it's to prevent the input file warnings since epsilon_cooling_factor is an attribute of the inversion options classes.
Contributor
There was a problem hiding this comment.
I pushed some other changes to this effect.
benk-mira
requested changes
Mar 24, 2025
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Not sure I understand the roles of the different meshes in here. Posted some feedback on structure of the InversionMesh class.
benk-mira
previously approved these changes
Mar 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
+ Coverage 89.62% 90.03% +0.40%
===========================================
Files 81 84 +3
Lines 4685 4787 +102
Branches 608 618 +10
===========================================
+ Hits 4199 4310 +111
+ Misses 328 321 -7
+ Partials 158 156 -2
🚀 New features to boost your workflow:
|
(cherry picked from commit 2f9c617) # Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # py-3.12.conda-lock.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-95 - Migrate em_inversion (EM1D) script to simpeg-drivers