Skip to content

GEOPY-2103: Migrate FEM-1D from simpeg-drivers#177

Merged
domfournier merged 12 commits intodevelopfrom
GEOPY-2103
Apr 2, 2025
Merged

GEOPY-2103: Migrate FEM-1D from simpeg-drivers#177
domfournier merged 12 commits intodevelopfrom
GEOPY-2103

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Mar 31, 2025

GEOPY-2103 - Migrate FEM-1D from simpeg-drivers

# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
#	pyproject.toml
@github-actions github-actions bot changed the title GEOPY-2103 GEOPY-2103: Migrate FEM-1D from simpeg-drivers Mar 31, 2025
Base automatically changed from GEOPY-95 to develop March 31, 2025 21:58
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. couple small comments

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 96.85039% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.15%. Comparing base (00813ed) to head (9f057ae).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...peg_drivers/components/factories/source_factory.py 77.77% 1 Missing and 1 partial ⚠️
simpeg_drivers/electromagnetics/base_1d_driver.py 96.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
+ Coverage    90.03%   90.15%   +0.11%     
===========================================
  Files           84       86       +2     
  Lines         4787     4814      +27     
  Branches       618      621       +3     
===========================================
+ Hits          4310     4340      +30     
+ Misses         321      317       -4     
- Partials       156      157       +1     
Files with missing lines Coverage Δ
simpeg_drivers/__init__.py 86.66% <ø> (ø)
simpeg_drivers/components/data.py 92.75% <100.00%> (ø)
...drivers/components/factories/directives_factory.py 96.58% <ø> (ø)
...peg_drivers/components/factories/misfit_factory.py 96.87% <100.00%> (ø)
...g_drivers/components/factories/receiver_factory.py 87.09% <100.00%> (+0.57%) ⬆️
...peg_drivers/components/factories/simpeg_factory.py 92.59% <ø> (ø)
...drivers/components/factories/simulation_factory.py 98.94% <100.00%> (+0.03%) ⬆️
...peg_drivers/components/factories/survey_factory.py 91.86% <100.00%> (ø)
simpeg_drivers/driver.py 88.02% <100.00%> (+0.03%) ⬆️
...rivers/electromagnetics/frequency_domain/params.py 87.80% <100.00%> (+5.66%) ⬆️
... and 8 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit a870101 into develop Apr 2, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2103 branch April 2, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants