Skip to content

GEOPY-2105: Make lower bound for MVI visible=False#178

Merged
domfournier merged 7 commits intodevelopfrom
GEOPY-2105
Apr 3, 2025
Merged

GEOPY-2105: Make lower bound for MVI visible=False#178
domfournier merged 7 commits intodevelopfrom
GEOPY-2105

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Mar 31, 2025

GEOPY-2105 - Make lower bound for MVI visible=False

@github-actions github-actions bot changed the title GEOPY-2105 GEOPY-2105: Make lower bound for MVI visible=False Mar 31, 2025
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (aea3db8) to head (2da66c6).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #178      +/-   ##
===========================================
+ Coverage    90.09%   90.11%   +0.02%     
===========================================
  Files           87       87              
  Lines         5028     5039      +11     
  Branches       642      644       +2     
===========================================
+ Hits          4530     4541      +11     
  Misses         332      332              
  Partials       166      166              
Files with missing lines Coverage Δ
simpeg_drivers/components/models.py 85.21% <100.00%> (+0.10%) ⬆️
...drivers/potential_fields/magnetic_scalar/params.py 100.00% <100.00%> (ø)
...drivers/potential_fields/magnetic_vector/params.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably warn if a real lower bound is passed to the options class for mvi.

@domfournier domfournier merged commit 8ad2083 into develop Apr 3, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2105 branch April 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants