GEOPY-2049: merge release branch to develop (+ GEOPY-2128)#189
Merged
GEOPY-2049: merge release branch to develop (+ GEOPY-2128)#189
Conversation
… differ because of rc or post qualifier
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #189 +/- ##
===========================================
+ Coverage 90.32% 90.33% +0.01%
===========================================
Files 87 87
Lines 5042 5051 +9
Branches 642 643 +1
===========================================
+ Hits 4554 4563 +9
Misses 326 326
Partials 162 162
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
tests/uijson_test.py:51
- [nitpick] Consider adding an inline comment to explain the choice of _current_version().public, ensuring clarity on how pre-release variants are normalized for testing purposes.
if version is None:
version = _current_version().public
simpeg_drivers/uijson.py:35
- [nitpick] The warning message now encloses version values in quotes; please ensure that tests capturing warning substrings remain robust to this updated formatting.
if input_version != package_version:
pyproject.toml:3
- Ensure that the new version string '0.4.0-alpha.1' is consistently used throughout the project and adheres to the expected pre-release naming conventions.
version = "0.4.0-alpha.1"
…n-tests GEOPY-2128: fix UI json version tests (part of GEOPY-2049)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup of GEOPY-2049 - environment for coming pre-release, merging back to develop branch
Same as #190 + bump version + relock onto develop branches
include fix for GEOPY-2128