GEOPY-2137: Use dask.distributed with workers as default behaviour#198
Merged
sebhmg merged 23 commits intorelease/0.3.0from Apr 25, 2025
Merged
GEOPY-2137: Use dask.distributed with workers as default behaviour#198sebhmg merged 23 commits intorelease/0.3.0from
sebhmg merged 23 commits intorelease/0.3.0from
Conversation
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # py-3.12.conda-lock.yml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #198 +/- ##
=================================================
- Coverage 90.35% 90.17% -0.18%
=================================================
Files 87 87
Lines 5060 5110 +50
Branches 645 654 +9
=================================================
+ Hits 4572 4608 +36
- Misses 326 338 +12
- Partials 162 164 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency configuration to use dask.distributed with workers as the default behavior by switching the mira-simpeg dependency from the PyPI release to a git version.
- Changed mira-simpeg dependency in pyproject.toml to use the "GEOPY-2137" git revision.
- Updated various conda lock files with new input hashes and bumped versions of packaging and setuptools.
Reviewed Changes
Copilot reviewed 46 out of 53 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated mira-simpeg dependency from PyPI to a git version with rev "GEOPY-2137". |
| environments/*.conda.lock.yml (all platforms and versions) | Updated input_hash values and bumped dependency versions (packaging, setuptools, etc.); pip entries now resolve mira-simpeg via a commit hash. |
Files not reviewed (7)
- simpeg_drivers-assets/uijson/direct_current_2d_forward.ui.json: Language not supported
- simpeg_drivers-assets/uijson/direct_current_2d_inversion.ui.json: Language not supported
- simpeg_drivers-assets/uijson/direct_current_3d_forward.ui.json: Language not supported
- simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json: Language not supported
- simpeg_drivers-assets/uijson/direct_current_batch2d_forward.ui.json: Language not supported
- simpeg_drivers-assets/uijson/direct_current_batch2d_inversion.ui.json: Language not supported
- simpeg_drivers-assets/uijson/fdem1d_forward.ui.json: Language not supported
Comments suppressed due to low confidence (1)
pyproject.toml:61
- Ensure that the git tag 'GEOPY-2137' in pyproject.toml correctly corresponds to the commit hash '730fa00953165f6fd5a87c3942d05cf8e0a7e164' used in the lock files for mira-simpeg.
mira-simpeg = {git = "https://github.com/MiraGeoscience/simpeg.git", rev = "GEOPY-2137", extras = ["dask"]}
…blish and test" This reverts commit 8d2fe2f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2137 - Use dask.distributed with workers as default behaviour
depends on MiraGeoscience/simpeg#84