Skip to content

GEOPY-2137: Use dask.distributed with workers as default behaviour#198

Merged
sebhmg merged 23 commits intorelease/0.3.0from
GEOPY-2137
Apr 25, 2025
Merged

GEOPY-2137: Use dask.distributed with workers as default behaviour#198
sebhmg merged 23 commits intorelease/0.3.0from
GEOPY-2137

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Apr 19, 2025

GEOPY-2137 - Use dask.distributed with workers as default behaviour

depends on MiraGeoscience/simpeg#84

@github-actions github-actions bot changed the title GEOPY-2137 GEOPY-2137: Use dask.distributed with workers as default behaviour Apr 19, 2025
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 82.41758% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.17%. Comparing base (1c8b37a) to head (f9b3fa7).
Report is 24 commits behind head on release/0.3.0.

Files with missing lines Patch % Lines
simpeg_drivers/driver.py 64.44% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.3.0     #198      +/-   ##
=================================================
- Coverage          90.35%   90.17%   -0.18%     
=================================================
  Files                 87       87              
  Lines               5060     5110      +50     
  Branches             645      654       +9     
=================================================
+ Hits                4572     4608      +36     
- Misses               326      338      +12     
- Partials             162      164       +2     
Files with missing lines Coverage Δ
...peg_drivers/components/factories/misfit_factory.py 97.00% <100.00%> (+0.12%) ⬆️
simpeg_drivers/electromagnetics/base_1d_driver.py 96.49% <100.00%> (+0.49%) ⬆️
simpeg_drivers/options.py 94.82% <100.00%> (+0.09%) ⬆️
simpeg_drivers/driver.py 86.61% <64.44%> (-2.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebhmg sebhmg requested review from benk-mira and Copilot April 23, 2025 04:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency configuration to use dask.distributed with workers as the default behavior by switching the mira-simpeg dependency from the PyPI release to a git version.

  • Changed mira-simpeg dependency in pyproject.toml to use the "GEOPY-2137" git revision.
  • Updated various conda lock files with new input hashes and bumped versions of packaging and setuptools.

Reviewed Changes

Copilot reviewed 46 out of 53 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated mira-simpeg dependency from PyPI to a git version with rev "GEOPY-2137".
environments/*.conda.lock.yml (all platforms and versions) Updated input_hash values and bumped dependency versions (packaging, setuptools, etc.); pip entries now resolve mira-simpeg via a commit hash.
Files not reviewed (7)
  • simpeg_drivers-assets/uijson/direct_current_2d_forward.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/direct_current_2d_inversion.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/direct_current_3d_forward.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/direct_current_batch2d_forward.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/direct_current_batch2d_inversion.ui.json: Language not supported
  • simpeg_drivers-assets/uijson/fdem1d_forward.ui.json: Language not supported
Comments suppressed due to low confidence (1)

pyproject.toml:61

  • Ensure that the git tag 'GEOPY-2137' in pyproject.toml correctly corresponds to the commit hash '730fa00953165f6fd5a87c3942d05cf8e0a7e164' used in the lock files for mira-simpeg.
mira-simpeg = {git = "https://github.com/MiraGeoscience/simpeg.git", rev = "GEOPY-2137", extras = ["dask"]}

@sebhmg sebhmg merged commit 3f4abe0 into release/0.3.0 Apr 25, 2025
9 checks passed
@sebhmg sebhmg deleted the GEOPY-2137 branch April 25, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants