Skip to content

GEOPY-2152: Bad referencing to transmitter id name#203

Merged
domfournier merged 6 commits intorelease/0.3.0from
GEOPY-2152
May 1, 2025
Merged

GEOPY-2152: Bad referencing to transmitter id name#203
domfournier merged 6 commits intorelease/0.3.0from
GEOPY-2152

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Apr 30, 2025

GEOPY-2152 - Bad referencing to transmitter id name

@github-actions github-actions bot changed the title GEOPY-2152 GEOPY-2152: Bad referencing to transmitter id name Apr 30, 2025
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (62e86be) to head (0109b6c).
Report is 13 commits behind head on release/0.3.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/0.3.0     #203   +/-   ##
==============================================
  Coverage          90.21%   90.21%           
==============================================
  Files                 87       87           
  Lines               5110     5110           
  Branches             656      656           
==============================================
  Hits                4610     4610           
  Misses               335      335           
  Partials             165      165           
Files with missing lines Coverage Δ
simpeg_drivers/components/factories/__init__.py 100.00% <100.00%> (ø)
...peg_drivers/components/factories/survey_factory.py 92.05% <100.00%> (ø)
simpeg_drivers/components/topography.py 92.72% <100.00%> (ø)
simpeg_drivers/options.py 94.82% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sebhmg
sebhmg previously approved these changes Apr 30, 2025
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does -1 mean no neighbour?
Would be good to have a test that cover the case you are fixing here.

@domfournier
Copy link
Collaborator Author

Correct, -1 is for a boundary cell, and we ended up adding an active cell on the last (corner) cell.

sebhmg
sebhmg previously approved these changes May 1, 2025
@domfournier domfournier merged commit 74d4ddc into release/0.3.0 May 1, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2152 branch May 1, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants