GEOPY-2152: Bad referencing to transmitter id name#203
Merged
domfournier merged 6 commits intorelease/0.3.0from May 1, 2025
Merged
GEOPY-2152: Bad referencing to transmitter id name#203domfournier merged 6 commits intorelease/0.3.0from
domfournier merged 6 commits intorelease/0.3.0from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #203 +/- ##
==============================================
Coverage 90.21% 90.21%
==============================================
Files 87 87
Lines 5110 5110
Branches 656 656
==============================================
Hits 4610 4610
Misses 335 335
Partials 165 165
🚀 New features to boost your workflow:
|
sebhmg
previously approved these changes
Apr 30, 2025
sebhmg
reviewed
May 1, 2025
Contributor
sebhmg
left a comment
There was a problem hiding this comment.
does -1 mean no neighbour?
Would be good to have a test that cover the case you are fixing here.
Collaborator
Author
|
Correct, -1 is for a boundary cell, and we ended up adding an active cell on the last (corner) cell. |
sebhmg
previously approved these changes
May 1, 2025
sebhmg
approved these changes
May 1, 2025
benk-mira
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2152 - Bad referencing to transmitter id name