Skip to content

GEOPY-2183: Outdated inversion_type for 3D FDEM #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 6 commits into from
May 14, 2025
Merged

GEOPY-2183: Outdated inversion_type for 3D FDEM #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84a43a5
Catch renaming of fem, augment unit test
domfournier May 13, 2025
1f765fe
Update fdem jsons
domfournier May 13, 2025
25b09c8
Remove reference to x and y channels altogether
domfournier May 14, 2025
8b5ee27
Remove old fem from factory_types
domfournier May 14, 2025
7abf143
Delete old default_ui_json constant
domfournier May 14, 2025
a244174
Remove from init
domfournier May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simpeg_drivers-assets/uijson/fdem_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"geoh5": "",
"monitoring_directory": "",
"workspace_geoh5": "",
"inversion_type": "fem",
"inversion_type": "fdem",
"physical_property": "conductivity",
"forward_only": true,
"data_object": {
Expand Down
2 changes: 1 addition & 1 deletion simpeg_drivers-assets/uijson/fdem_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"geoh5": "",
"monitoring_directory": "",
"workspace_geoh5": "",
"inversion_type": "fem",
"inversion_type": "fdem",
"physical_property": "conductivity",
"forward_only": false,
"data_object": {
Expand Down
2 changes: 0 additions & 2 deletions simpeg_drivers-assets/uijson/tdem1d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
"tooltip": "Set the units of the data",
"value": "dB/dt (T/s)"
},
"x_channel_bool": "",
"y_channel_bool": "",
"z_channel_bool": {
"group": "Survey",
"main": true,
Expand Down
4 changes: 0 additions & 4 deletions simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
"tooltip": "Set the units of the data",
"value": "dB/dt (T/s)"
},
"x_channel": "",
"y_channel": "",
"z_channel": {
"association": [
"Cell",
Expand All @@ -50,8 +48,6 @@
"enabled": true,
"value": ""
},
"x_uncertainty": "",
"y_uncertainty": "",
"z_uncertainty": {
"association": [
"Cell",
Expand Down
15 changes: 8 additions & 7 deletions simpeg_drivers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,10 @@
import logging
from pathlib import Path

from simpeg_drivers.constants import default_ui_json


logging.basicConfig(level=logging.INFO)

__all__ = [
"DRIVER_MAP",
"assets_path",
"default_ui_json",
]
__all__ = ["DRIVER_MAP", "assets_path"]


def assets_path() -> Path:
Expand Down Expand Up @@ -96,6 +90,13 @@ def assets_path() -> Path:
"inversion": "FDEMInversionDriver",
},
),
"fem": (
"simpeg_drivers.electromagnetics.frequency_domain.driver",
{
"forward": "FDEMForwardDriver",
"inversion": "FDEMInversionDriver",
},
),
"fdem 1d": (
"simpeg_drivers.electromagnetics.frequency_domain_1d.driver",
{
Expand Down
Loading