GEOPY-2143: ensure backward compatibility of saved ui.json from Analyst 4.5 to 4.6

[domfournier]

GEOPY-2143 - ensure backward compatibility of saved ui.json from Analyst 4.5 to 4.6

[sebhmg]

nice to have this!

But... what is the fix which make them backward compatible? I thought there was a problem to address beyond having tests.

Also, the legacy ui.json files must be moved under the test folder.
Please see a couple of other questions.

[sebhmg]

question: is it changing back to the legacy inversion type?

or it this one the new one, which was already backward compatibly?

[domfournier]

I made this helper function to use the same strings as stored on geoh5, so that the test for the legacy uijson can build the demos directly. These were hardcoded before.

The airborne tdem 1d is new to 0.3.0, so not part of legacy.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (7baad45) to head (62eaa23).
Report is 15 commits behind head on release/0.3.0.

Files with missing lines	Patch %	Lines
simpeg_drivers/driver.py	66.66%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           release/0.3.0     #211      +/-   ##
=================================================
+ Coverage          90.36%   90.46%   +0.09%     
=================================================
  Files                 86       85       -1     
  Lines               5107     4927     -180     
  Branches             657      636      -21     
=================================================
- Hits                4615     4457     -158     
+ Misses               329      308      -21     
+ Partials             163      162       -1     

Files with missing lines	Coverage Δ
simpeg_drivers/driver.py	85.46% <66.66%> (-1.15%)	⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[domfournier]

But... what is the fix which make them backward compatible? I thought there was a problem to address beyond having tests.

This test confirms that all legacy (0.2.0) jsons are already compatible with 0.3.0 - at least running defaults with core parameters.

We will continue testing going forward to make sure that future changes will preserve the compatibility.